Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace “cloud.redhat.com” with “console.redhat.com” #3365

Merged
merged 1 commit into from
Apr 7, 2022

Conversation

strider
Copy link
Contributor

@strider strider commented Mar 23, 2022

All Pull Requests:

Check all that apply:

  • Have you followed the guidelines in our Contributing document, including the instructions about commit messages?
  • Is this PR to correct an issue?
  • Is this PR an enhancement?

Complete Description of Additions/Changes:

This PR fixes https://bugzilla.redhat.com/show_bug.cgi?id=2006386 by replacing all string occurrences of "cloud.redhat.com" with "console.redhat.com".

This patch replaces all the string occurrences of “cloud.redhat.com”
with “console.redhat.com”.

Resolved: rhbz#2006386

Signed-off-by: Gael Chamoulaud (Strider) <[email protected]>
@strider strider requested review from subpop, ahitacat and bfahr March 23, 2022 16:25
@bfahr bfahr added the client These issues represent work to be done by the "client" team. label Mar 23, 2022
@subpop
Copy link
Collaborator

subpop commented Mar 23, 2022

Do we know if we are ready to change the API URLs to console.redhat.com?

@strider
Copy link
Contributor Author

strider commented Mar 23, 2022

Do we know if we are ready to change the API URLs to console.redhat.com?

This patch mostly changes logger messages or comments. Good question though!

@ahitacat
Copy link
Contributor

Why this is not a constant?

@subpop
Copy link
Collaborator

subpop commented Mar 24, 2022

Why this is not a constant?

The API URL is a config option (base_url I think). But all these random strings are not a single constant because (my guess is) no one assumed the base host name would ever need to be changed

@xiangce
Copy link
Contributor

xiangce commented Mar 31, 2022

Hi @subpop and @ahitacat, I was trying to merge this PR since Bob has approved it. However, since you are also requested for the review, May I have your approvals before merging it? Thanks.

Copy link
Contributor

@ahitacat ahitacat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xiangce xiangce merged commit 0954194 into RedHatInsights:master Apr 7, 2022
xiangce pushed a commit that referenced this pull request Apr 7, 2022
This patch replaces all the string occurrences of “cloud.redhat.com”
with “console.redhat.com”.

Resolved: rhbz#2006386

Signed-off-by: Gael Chamoulaud (Strider) <[email protected]>
(cherry picked from commit 0954194)
xiangce pushed a commit that referenced this pull request Sep 6, 2024
This patch replaces all the string occurrences of “cloud.redhat.com”
with “console.redhat.com”.

Resolved: rhbz#2006386

Signed-off-by: Gael Chamoulaud (Strider) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client These issues represent work to be done by the "client" team.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants